fix: Use theming instead of custom background prop #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
amalv
commented
Dec 17, 2019
amalv
commented
- Remove backgroundcolor prop from Contextual styles
- Fix hover flickering errors
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/amalv/circleback-design-system/glb83bkgf |
- Use theming instead of custom background prop - Remove backgroundcolor prop from Contextual styles - Fix hover flickering errors - Remove styles provider
amalv
force-pushed
the
fix-contextual-button-theming
branch
from
11ce67e
to
c69699f
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Dec 17, 2019
## [1.24.1](v1.24.0...v1.24.1) (2019-12-17) ### Bug Fixes * contextual component ([#141](#141)) ([ae50d4d](ae50d4d))
|
🎉 This PR is included in version 1.24.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.